Skip to content

Conversation

MasterKale
Copy link
Contributor

  • Updated activate() to handle a bug that enabled access to non-public routes after loading a public route
  • Updated publicRoutes to reflect values returned by ComponentInstruction.urlPath
  • Added a small comment clarifying the purpose of the boolean assigned to each route in publicRoutes

- Updated `activate()` to handle a bug that enabled access to non-public routes after loading a public route
- Updated `publicRoutes` to reflect values returned by `ComponentInstruction.urlPath`
- Added a small comment clarifying the purpose of the boolean assigned to each route in `publicRoutes`
@MasterKale
Copy link
Contributor Author

I discovered an issue in LoggedInOutlet that allowed you to load a non-public route after loading a public route. To recreate the issue, load the /login route and then change the URL in the address bar and go to /home. The /home route will load because this.parentRouter.lastNavigationAttempt will return /login, which IS a public route.

Calling instance.urlPath will return the route that is currently being navigated to and will redirect accordingly if the route is not in publicRoutes.

@ojacquemart
Copy link

👍, I noticed the same issue.

@chenkie chenkie merged commit 91f67a3 into auth0-blog:master Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants