[SIL-opaque] Don't override arg value category.

[nate-chandler]

Previously, when emitting block arguments, the value category of the SILType was overridden to be address for indirect arguments. With opaque types, that distinction is made later during AddressLowering. So only do that when opaque types are disabled.

[nate-chandler]

Without opaque values:

sil private [ossa] @$sSa4mainSiRszlE20incrementEachElementSaySiGyFS2iXEfU_ : $@convention(thin) @substituted <τ_0_0, τ_0_1> (@in_guaranteed τ_0_0) -> @out τ_0_1 for <Int, Int> {
// %0 "$return_value"                             // user: %11
// %1 "element"                                   // user: %2
bb0(%0 : $*Int, %1 : $*Int):
  %2 = load [trivial] %1 : $*Int, loc "main.swift":9:35, scope 6 // users: %10, %3
  debug_value %2 : $Int, let, name "element", argno 1, loc "main.swift":9:35, scope 6 // id: %3
  %4 = metatype $@thin Int.Type, loc "main.swift":10:22, scope 7 // user: %10
  %5 = integer_literal $Builtin.IntLiteral, 1, loc "main.swift":10:24, scope 7 // user: %8
  %6 = metatype $@thin Int.Type, loc "main.swift":10:24, scope 7 // user: %8
  // function_ref Int.init(_builtinIntegerLiteral:)
  %7 = function_ref @$sSi22_builtinIntegerLiteralSiBI_tcfC : $@convention(method) (Builtin.IntLiteral, @thin Int.Type) -> Int, loc "main.swift":10:24, scope 7 // user: %8
  %8 = apply %7(%5, %6) : $@convention(method) (Builtin.IntLiteral, @thin Int.Type) -> Int, loc "main.swift":10:24, scope 7 // user: %10
  // function_ref static Int.+ infix(_:_:)
  %9 = function_ref @$sSi1poiyS2i_SitFZ : $@convention(method) (Int, Int, @thin Int.Type) -> Int, loc "main.swift":10:22, scope 7 // user: %10
  %10 = apply %9(%2, %8, %4) : $@convention(method) (Int, Int, @thin Int.Type) -> Int, loc "main.swift":10:22, scope 7 // user: %11
  store %10 to [trivial] %0 : $*Int, loc "main.swift":10:22, scope 7 // id: %11
  %12 = tuple (), loc "main.swift":11:5, scope 7  // user: %13
  return %12 : $(), loc "main.swift":10:7, scope 7 // id: %13
} // end sil function '$sSa4mainSiRszlE20incrementEachElementSaySiGyFS2iXEfU_'

With opaque values and this patch:

// closure #1 in Array<A>.incrementEachElement()
sil private [ossa] @$sSa4mainSiRszlE20incrementEachElementSaySiGyFS2iXEfU_ : $@convention(thin) @substituted <τ_0_0, τ_0_1> (@in_guaranteed τ_0_0) -> @out τ_0_1 for <Int, Int> {
// %0 "element"                                   // users: %8, %1
bb0(%0 : $Int):
  debug_value %0 : $Int, let, name "element", argno 1, loc "main.swift":9:35, scope 6 // id: %1
  %2 = metatype $@thin Int.Type, loc "main.swift":10:22, scope 7 // user: %8
  %3 = integer_literal $Builtin.IntLiteral, 1, loc "main.swift":10:24, scope 7 // user: %6
  %4 = metatype $@thin Int.Type, loc "main.swift":10:24, scope 7 // user: %6
  // function_ref Int.init(_builtinIntegerLiteral:)
  %5 = function_ref @$sSi22_builtinIntegerLiteralSiBI_tcfC : $@convention(method) (Builtin.IntLiteral, @thin Int.Type) -> Int, loc "main.swift":10:24, scope 7 // user: %6
  %6 = apply %5(%3, %4) : $@convention(method) (Builtin.IntLiteral, @thin Int.Type) -> Int, loc "main.swift":10:24, scope 7 // user: %8
  // function_ref static Int.+ infix(_:_:)
  %7 = function_ref @$sSi1poiyS2i_SitFZ : $@convention(method) (Int, Int, @thin Int.Type) -> Int, loc "main.swift":10:22, scope 7 // user: %8
  %8 = apply %7(%0, %6, %2) : $@convention(method) (Int, Int, @thin Int.Type) -> Int, loc "main.swift":10:22, scope 7 // user: %9
  return %8 : $Int, loc "main.swift":10:7, scope 7 // id: %9
} // end sil function '$sSa4mainSiRszlE20incrementEachElementSaySiGyFS2iXEfU_'