Add suppor for bigint to bitwise BIFs #1738
Open
+924
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
biggerint-bitwise
branch
2 times, most recently
from
db12deb to
80a3a7e
Compare
bettio
force-pushed
the
biggerint-bitwise
branch
9 times, most recently
from
803e9e5 to
106850c
Compare
Refactor `bitwise_helper` so it can be changed later for bigint support. Signed-off-by: Davide Bettio <[email protected]>
Add: - `intn_bormn` - `intn_bandmn` - `intn_bxormn` Signed-off-by: Davide Bettio <[email protected]>
Update `bitwise_helper` in order to use new bitwise functions from `intn`. Signed-off-by: Davide Bettio <[email protected]>
Add: - `intn_bsl` - `intn_bsr` Signed-off-by: Davide Bettio <[email protected]>
Update `bsl` and `bsr` functions in order to support bigints. This also removes overflows and undefined behaviors from shift functions. Signed-off-by: Davide Bettio <[email protected]>
Signed-off-by: Davide Bettio <[email protected]>
Just use `intn_bnot` in order to handle bigint arguments. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
biggerint-bitwise
branch
from
106850c to
aa0245c
Compare
pguyot
reviewed
Sep 20, 2025
| carry = temp >> 32; | ||
| } | ||
| if (carry) { | ||
| out[i] = carry; |
There was a problem hiding this comment.
I am confused by this. Does it overflow out? i is equal to len at this point.
| Signedness <- [unsigned] | ||
| ], | ||
| % TODO: make this test work again | ||
| % Explaination: |
There was a problem hiding this comment.
s/Explaination/Explanation/
|
|
||
| size_t intn_bsl(const uint32_t num[], size_t len, size_t n, uint32_t *out); | ||
| size_t intn_bsr( | ||
| const uint32_t num[], size_t len, intn_integer_sign_t num_sign, size_t n, uint32_t *out); |
| size_t intn_bnot(const intn_digit_t m[], size_t m_len, intn_integer_sign_t m_sign, | ||
| intn_digit_t out[], intn_integer_sign_t *out_sign); | ||
|
|
||
| size_t intn_bsl(const uint32_t num[], size_t len, size_t n, uint32_t *out); |
|
|
||
| if (arg1_size <= BOXED_TERMS_REQUIRED_FOR_INT64) { | ||
| uint64_t a = (uint64_t) term_maybe_unbox_int64(arg1); | ||
| int64_t result = int64_bsr_safe(a, b); |
There was a problem hiding this comment.
int64_bsr_safe takes int64_t so you don't need to cast the result of term_maybe_unbox_int64 to uint64_t
| uint32_t maybe_last_out = (last_digit >> right_shift_n); | ||
|
|
||
| if (initial_zeros + i > new_digits_count) { | ||
| abort(); |
There was a problem hiding this comment.
Is this assert or should we raise?
| intn_digit_t *n; | ||
| size_t n_len; | ||
| intn_integer_sign_t n_sign; | ||
| args_to_bigint(arg1, arg2, tmp_buf1, tmp_buf2, &m, &m_len, &m_sign, &n, &n_len, &n_sign); |
There was a problem hiding this comment.
n is not used here, we already decided it's a smaller int. So term_to_bigint(arg1, tmp_buf1, &m, &m_len, &m_sign); is sufficient.
| intn_digit_t *n; | ||
| size_t n_len; | ||
| intn_integer_sign_t n_sign; | ||
| args_to_bigint(arg1, arg2, tmp_buf1, tmp_buf2, &m, &m_len, &m_sign, &n, &n_len, &n_sign); |
There was a problem hiding this comment.
n is not used here either, see comment on bsl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for bigint to:
bsl/bsrband/bor/bxorbnotAlso
bsl/bsrdo not depend anymore or undefined behaviors (and they may raise overflow exception).These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later