This repository was archived by the owner on Apr 6, 2018. It is now read-only.
fix some more command->normal mode renames #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronson
force-pushed
the
command-to-normal
branch
from
2f6a2a4 to
a274ea6
Compare
bronson
changed the title
bronson
changed the title
spec/motions-spec.coffee
Outdated
Contributor
There was a problem hiding this comment.
normalEditor sounds so generic; maybe normalModeInputEditor? Or inputEditor?
Contributor
There was a problem hiding this comment.
Same below in "using search history".
Contributor
|
I'll wait with my rebases until this one gets merged, if that's all right. 8-) |
Contributor
Author
|
Agreed, inputEditor seems nice and readable. Updated! I also agree with avoiding rebases until things settle down. That said, I already did vim-mode-next... everything seems OK. bronson/vim-mode-next@80ad67c |
maxbrunsfeld
pushed a commit
that referenced
this pull request
Jul 21, 2015
fix some more command->normal mode renames
Contributor
|
👀 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All style, very little substance.