Skip to content
This repository was archived by the owner on Apr 6, 2018. It is now read-only.

Conversation

@coolwanglu
Copy link
Contributor

This patch adds a 'prefix' to the command mode input when necessary.
And currently only the / motion is supported, any other motion we should support?

When '/' is pressed, '/' is shown in the beginning of the input, and when '/' is removed, the motion is cancelled naturally.

But this is not perfect, since we can select & paste the prefix, which is not possible in vim. We might want to disable selection of the command mode input.

I think with this, we can easily support some command-line mode commands (: commands)?

@coolwanglu
Copy link
Contributor Author

Oh this conflicts with search history.
I'm not pretty sure about how histories are organized in native vim, but we may cache all the commands and search the history through prefixes. Which is also good for the future support for : commands.

@coolwanglu
Copy link
Contributor Author

Also we might want to prevent the cursor being moved to the beginning when prefixChar is presented.

@coolwanglu
Copy link
Contributor Author

Now all specs are passed.
Please review.

@bronson
Copy link
Contributor

bronson commented Jul 3, 2015

I resurrected this branch to evaluate it: https://github.com/bronson/vim-mode/commits/prefix-char

It looks like #582 has blown it away. It would probably be easier to rewrite the patch than to resolve the merge conflicts.

I don't understand why this was never reviewed. :(

@ardrigh
Copy link

ardrigh commented Jul 6, 2015

It would be nice if these features could be reviewed along with what https://github.com/lloeki/ex-mode is doing with the commands. I added a similar request to that package (lloeki/ex-mode#61) to add : to the start of the command input, as a visual indication of command input.

If vim-mode and ex-mode merged together, then these requests would be better handled IMO.

Vim uses / for search but :%s for search & replace, and both should ideally be handled together. It might also save a lot of work supporting things like search history commands.

@lee-dohm
Copy link
Contributor

lee-dohm commented Apr 5, 2018

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!

@lee-dohm lee-dohm closed this Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants