This repository was archived by the owner on Apr 6, 2018. It is now read-only.
optimize find motion visual effect #432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Anybody give some feedback ? |
Contributor
|
Similar to discussion in #653, this is probably best implemented by adding a hook to vim-mode, then doing the highlighting in a separate plugin. |
This was referenced Jul 4, 2015
Contributor
|
As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I optimize the visual effect of search motion using Atom's decoration flash effect.
https://github.com/atom/atom/blob/v0.141.0/src/decoration.coffee#L162
Since https://github.com/atom/atom/blob/v0.141.0/src/highlight-component.coffee#L42 doesn't provide a callback after completion, I use setTimeout() to destroy the marker.
Following is the screenshot
