This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Calculate newEnd correctly when line ending normalization takes place
#256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of #255, we changed the way the `onDidChangeText` and `onDidStopChanging` collected changes so that they could avoid relying on the history (see 8a4a4d8 for more background). Later, in ce1964f, we improved the performance of combining the accumulated changes by also storing the change's `newEnd`. This was, however, slightly incorrect, as we calculated such coordinate before normalizing line endings, thus causing the various text change events to report inaccurate information. With this commit we are fixing that oversight (adding also test coverage to ensure we don't regress in the future), as well as streamlining `applyChange`. In particular, we will now take care of normalizing lines in `setTextInRange` instead of `applyChange`, as that's the only call site in which normalization needs to take place.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #255, we changed the way the
onDidChangeTextandonDidStopChangingcollected changes so that they could avoid relying on the history (see 8a4a4d8 for more background).Later, in ce1964f, we improved the performance of combining the accumulated changes by also storing the change's
newEnd. This was, however, slightly incorrect, as we calculated such coordinate before normalizing line endings, thus causing the various text change events to start reporting inaccurate information.With this pull-request we are fixing that oversight (adding also test coverage to ensure we don't regress in the future), as well as streamlining
applyChange. In particular, we will now take care of normalizing lines insetTextInRangeinstead ofapplyChange, as that's the only call site in which normalization needs to take place./cc: @nathansobo