This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Accept and cancel buttons on Git identity panel #2587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Instead of writing your username and email directly to git configuration as you type, use an explicit accept button press. While I'm at it, add separate accept buttons to write to repo-local vs. global git configuration, and add more explanation text to ensure that users know what the control is doing.
The "use for this repository" button is disabled in contexts where there is no local repository.
Screenshot or Gif
Applicable Issues
Fixes #2557.