Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@wadethestealth
Copy link
Contributor

@wadethestealth wadethestealth commented Oct 8, 2019

Description of the Change

Moved to WIP awaiting discussion and #2325

  • Adds the ability to change remotes for GitHub PR Reviews
  • Adds a GitHub tab heading to show which remote you are on.
    • Adds a selector to swap remotes

Current Design:

TBD

Alternate Designs

Up to discussion.

Benefits

  • This will add Atom support to workflows that often work with multiple remotes.

Possible Drawbacks

Possible draw backs are the number of remotes someone could have and how we should handle that. I have made note of visualizing lists in react from official react docs, just in case we need to investigate this.

Applicable Issues

#555, #870 (This seems stale, but there are some nice ideas in there that I would like to take over) and #1934 (Prototype for the UI of Remote Management)

Metrics

N/A

Tests

N/A

Documentation

  • Added Feature Request Doc

Release Notes

TBD

User Experience Research (Optional)

TBD


cc: @simurai @smashwilson

View rendered docs/feature-requests/007-remote-management.md

@wadethestealth wadethestealth changed the title Feature Request: Remote Management Feature Proposal: Remote Management Oct 8, 2019
@wadethestealth wadethestealth changed the title Feature Proposal: Remote Management Feature Proposal: Remote Management (Github Tab Only) Oct 10, 2019
@wadethestealth wadethestealth changed the title Feature Proposal: Remote Management (Github Tab Only) WIP: Remote Management Oct 15, 2019
@wadethestealth
Copy link
Contributor Author

@smashwilson I know we briefly discussed putting remotes inside the project header of #2308, however, I was just wondering what your opinion was on a potential workflow issue.

  • If I mostly work and commit on a personal fork, but then open PR's on a remote upstream, it could become awkward to switch remotes on the header just when I want to view a PR and then switch back when I see something I want to change.
    • Once a review is open, it doesn't truly matter anymore which context I am in because the review can always stay loaded. However, I wonder if it could be beneficial to have separate remote selection for git and github. Thoughts?

@wadethestealth wadethestealth changed the base branch from master to prototypes/fr1934-context October 24, 2019 05:50
@wadethestealth wadethestealth changed the base branch from prototypes/fr1934-context to master October 24, 2019 05:50
@wadethestealth
Copy link
Contributor Author

Was kinda taken over by the project management pr. This feature is still not available, but this code requires a complete restructure as it has drifted far from master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants