This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Couldn't load subscription status.
- Fork 406
Create and publish dialog #2222
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
+ Coverage 92.75% 92.76% +0.01%
==========================================
Files 219 222 +3
Lines 12322 12355 +33
Branches 1793 1798 +5
==========================================
+ Hits 11429 11461 +32
- Misses 893 894 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
+ Coverage 92.75% 93.28% +0.53%
==========================================
Files 219 228 +9
Lines 12322 12889 +567
Branches 1793 1846 +53
==========================================
+ Hits 11429 12024 +595
+ Misses 893 865 -28
Continue to review full report at Codecov.
|
1 task
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Add a dialog that:
Within the scope of this pull request, these will be triggered with
github:create-repositoryandgithub:publish-repositorycommands on the command palette. They'll additionally be triggered from the GitHub tab's blank state in later work.Remaining work
CreateDialogControllerout ofCreateDialogView.CreateDialogContainerto render theCreateDialogViewwithin a query rendererCreateDialogcomponentCreateDialogBrowserWindowfrom the Atom environment to theCreateDialogViewRepositoryHomeSelectionViewCreateDialogup to commands inRootControllerCreateDialogTextEditorelements has a tab index of-1. This interferes with the ability of Atom'score:focus-nextandcore:focus-previouscommands to correctly navigate among elements with sequential positivetabIndexvalues when any of them are<atom-text-editor>elements.Screenshot/Gif
TODO
Alternate Designs
N/A
Benefits
Users will be able to create GitHub repositories from within Atom.
Possible Drawbacks
N/A
Applicable Issues
This is the first independent chunk of the work for feature request outlined in #2111.
Metrics
TODO
Tests
Manual verification:
github:create-repository.github:publish-repository.Documentation
TODO
Release Notes
github:create-repositorycommand.github:publish-repositorycommand.User Experience Research (Optional)
N/A