Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jun 6, 2019

🤖 This automated pull request brought to you by a GitHub action 🤖

The GraphQL schema has been updated and relay-compiler has been re-run on the package source. relay-compiler failed with the following output:


Writing js
ERROR:
RelayParser: Encountered 2 error(s):
- Unknown field 'timeline' on type 'Issue'. Source: document `issueTimelineController_issue` file: `controllers/issue-timeline-controller.js`
  
  controllers/issue-timeline-controller.js (8:7)
  7:       url
  8:       timeline(
           ^
  9:         first: $timelineCount, after: $timelineCursor
  
- Unknown field 'timeline' on type 'PullRequest'. Source: document `prTimelineController_pullRequest` file: `controllers/pr-timeline-controller.js`
  
  controllers/pr-timeline-controller.js (9:7)
   8:       ...headRefForcePushedEventView_issueish
   9:       timeline(first: $timelineCount, after: $timelineCursor) @connection(key: "prTimelineContainer_timeline") {
            ^
  10:         pageInfo { endCursor hasNextPage }
  

🚨 Check out this branch to fix things so we don't break. 🚨

@github-actions github-actions bot added the schema update Automated pull requests that validate updates to the GraphQL schema. label Jun 6, 2019
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #2177 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
- Coverage   92.72%   92.66%   -0.07%     
==========================================
  Files         215      215              
  Lines       12269    12271       +2     
  Branches     1796     1796              
==========================================
- Hits        11377    11371       -6     
- Misses        892      900       +8
Impacted Files Coverage Δ
lib/controllers/pr-timeline-controller.js 33.33% <ø> (ø) ⬆️
...views/timeline-items/commit-comment-thread-view.js 100% <ø> (ø) ⬆️
lib/controllers/issue-timeline-controller.js 0% <ø> (ø) ⬆️
lib/views/issueish-timeline-view.js 97.91% <100%> (ø) ⬆️
lib/views/timeline-items/commits-view.js 100% <100%> (ø) ⬆️
lib/git-temp-dir.js 90.9% <0%> (-9.1%) ⬇️
lib/helpers.js 87.24% <0%> (-1.65%) ⬇️
lib/github-package.js 66.79% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e2eda2...faa0aa9. Read the comment docs.

@smashwilson
Copy link
Contributor

Here's the breaking change associated with this. Looks like an easy fix:

https://developer.github.com/v4/breaking_changes/#changes-scheduled-for-2019-10-01

@smashwilson smashwilson merged commit a1e5945 into master Jul 6, 2019
@smashwilson smashwilson deleted the schema-update/1559782934969 branch July 6, 2019 15:38
@smashwilson smashwilson mentioned this pull request Jul 18, 2019
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

schema update Automated pull requests that validate updates to the GraphQL schema.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants