Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@smashwilson
Copy link
Contributor

More GitHub Action fun ⚡

This one will run each time we assign an issue or open a pull request. It'll add the issue or pull request to the current release project board so we keep that as an accurate record of the work that's been done within each release cycle.

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #2131 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2131      +/-   ##
==========================================
+ Coverage   92.72%   92.73%   +<.01%     
==========================================
  Files         207      207              
  Lines       12053    12053              
  Branches     1764     1764              
==========================================
+ Hits        11176    11177       +1     
+ Misses        877      876       -1
Impacted Files Coverage Δ
lib/models/operation-states.js 91.66% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131afd2...38e6200. Read the comment docs.

@smashwilson
Copy link
Contributor Author

Tested with #2132. Looks like it added itself to the release project correctly ⚡

@smashwilson smashwilson marked this pull request as ready for review May 8, 2019 16:30
@smashwilson smashwilson requested a review from a team May 8, 2019 16:30
Copy link
Contributor

@vanessayuenn vanessayuenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see how this will work! Something that would be neat is to add an action triggered by us unassigning issues, which will take the issue off the current project board. It's just an 💡 idea 💡 though.

query {
repository(owner: "atom", name: "github") {
projects(
search: "Release"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the matching be case sensitive, then? And is this search only on the name of the project board?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search is only on the name of the board:

https://developer.github.com/v4/object/repository/, search for "projects"

Query to search projects by, currently only searching by name.

I'm not sure if it's case sensitive or not, though? The one I tested with was an exact case match 🤔

args = "action 'opened|merged|assigned|reopened'"
}

action "Add pull request to release board" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are "add" vs "consider" distinguished here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, "consider" filters on the event's action to determine whether or not it should result in a release board addition; "add" does the actual addition.

@smashwilson smashwilson merged commit edbb26d into master May 14, 2019
@smashwilson smashwilson deleted the aw/auto-add-to-sprint branch May 14, 2019 13:39
@smashwilson smashwilson mentioned this pull request Jul 18, 2019
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants