Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Make review comments editable #2124

Merged
merged 93 commits into from
May 15, 2019
Merged

Make review comments editable #2124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
4105407
Add context menu for comments
kuychaco May 3, 2019
e0ab1dd
Add "Open on GitHub" menu item
kuychaco May 3, 2019
e7e7a97
Add "Report abuse" menu item
kuychaco May 3, 2019
0eaf159
Use arrow function to ensure proper this binding
kuychaco May 3, 2019
8061849
Get comment body from graphql API
kuychaco May 3, 2019
d49149c
Extract ReviewCommentView
kuychaco May 3, 2019
1c13cad
Display editor when "Edit" menu item is clicked
kuychaco May 4, 2019
d0fb685
Cancel editing message, prompting first if text had been changed
kuychaco May 4, 2019
77bb4be
get started with a new RFC for the reviewer flow
vanessayuenn Apr 19, 2019
adc7c8a
add some draft about the overview of components
vanessayuenn Apr 19, 2019
1743c93
add some outline for the workflow explanation
vanessayuenn Apr 19, 2019
d61ff6b
grammar
vanessayuenn Apr 19, 2019
bc56c79
add header screenshot
vanessayuenn Apr 19, 2019
7da3f97
add an alternative to header :thinking:
vanessayuenn Apr 24, 2019
14cedc0
Add some screenshots
vanessayuenn Apr 24, 2019
63ae918
New comment screenshot
vanessayuenn Apr 24, 2019
4fd9f61
add section on "add comment" gutter icon flow
vanessayuenn Apr 24, 2019
8b148c9
add section on high level workflow
vanessayuenn Apr 24, 2019
d7a839d
moved some sections around
vanessayuenn Apr 24, 2019
fba35e5
add section about pending review summary
vanessayuenn Apr 24, 2019
0414e62
add section about pending comments
vanessayuenn Apr 24, 2019
3c8791c
fix format
vanessayuenn Apr 24, 2019
962416e
in-page links
vanessayuenn Apr 24, 2019
18be874
split up the comment threads
vanessayuenn Apr 29, 2019
0c1a39c
add some styling
vanessayuenn Apr 29, 2019
b736682
When resolving/unresolving threads, use highlights to hint at users t…
vanessayuenn Apr 29, 2019
6b01837
consistently use `highlightThread()` to control thread highlighting
vanessayuenn Apr 30, 2019
82c8ad6
Update docs/feature-requests/006-pull-request-reviewer-flow.md
smashwilson May 1, 2019
cb3e6d7
update RFC based on comments
vanessayuenn May 1, 2019
5e3c80f
fill in part 2 of RFC
vanessayuenn May 1, 2019
8d6c6bc
fix markdown table syntax
vanessayuenn May 1, 2019
49b4d9b
scroll into view upon resolving/unresolving a thread
vanessayuenn May 2, 2019
23472c6
remove duplications
vanessayuenn May 2, 2019
e69e2fa
i slept on it and decided that was a bad idea.
vanessayuenn May 2, 2019
0bd304c
add missing proptype
vanessayuenn May 2, 2019
6e6e718
fix tests
vanessayuenn May 2, 2019
764a81f
styling
vanessayuenn May 2, 2019
5dbefe9
Default upstream refspec to `master`
smashwilson May 6, 2019
8a09603
Let's try again tonight
smashwilson May 6, 2019
123eca4
Cron syntax is hard
smashwilson May 6, 2019
6b06b8c
add/modify some tests
vanessayuenn May 6, 2019
e5177ea
Use a full refspec and only use HEAD locally
smashwilson May 7, 2019
f89aa4d
On to wednesday :calendar:
smashwilson May 7, 2019
e6e02f2
Prepare 0.28.0 release
smashwilson Apr 8, 2019
5d34670
Prepare 0.29.0 release
smashwilson May 8, 2019
a34a7e4
Merge branch 'master' into pr-2124/atom/ku-edit-comments
vanessayuenn May 8, 2019
5381604
add missing proptypes
vanessayuenn May 8, 2019
4f0048f
add some styling for the footer buttons
vanessayuenn May 8, 2019
4564240
add empty edit comment function
vanessayuenn May 8, 2019
d970678
drill em props
vanessayuenn May 8, 2019
79e9077
do the mutation
vanessayuenn May 8, 2019
21d0e0c
optimistically update comment body
vanessayuenn May 8, 2019
9269a85
but actaully parse the comment from markdown to html first
vanessayuenn May 8, 2019
f41c9e4
fix button margin
vanessayuenn May 8, 2019
2dfa257
refractor out the comment editor to a reusable component
vanessayuenn May 9, 2019
7706a8d
naming is hard
vanessayuenn May 9, 2019
cb3dd75
some clean up
vanessayuenn May 9, 2019
5462fc1
use smaller buttons
vanessayuenn May 9, 2019
ef60405
get `body` field for review summary too
vanessayuenn May 9, 2019
54b4815
use `ActionableReviewView` with summaries
vanessayuenn May 9, 2019
0931285
styling! also rename `editComment` to something more generic
vanessayuenn May 9, 2019
a7efd84
add update review summary mutation
vanessayuenn May 9, 2019
c866360
actually hook up the mutation with UI
vanessayuenn May 9, 2019
fc046ad
add some metrics tings :sparkles:
vanessayuenn May 9, 2019
15af3b8
query for `viewerCanUpdate` also so we know whether to show the edit …
vanessayuenn May 9, 2019
ec49a59
only show edit option if user has the right permission
vanessayuenn May 9, 2019
8dc48a6
PropTypes: confirm is a func :ok_hand:
smashwilson May 10, 2019
fcd563f
Focus the TextEditor when entering an edit state
smashwilson May 10, 2019
d96a0bd
Drill the CommandRegistry into ActionableReviewView
smashwilson May 10, 2019
313ebc8
Store the TextBuffer as an instance var instead of creating on render
smashwilson May 10, 2019
aabd67f
Bind core:confirm and core:cancel within ActionableReviewView
smashwilson May 10, 2019
410ca78
We want github:submit-comment for cmd/ctrl-enter
smashwilson May 10, 2019
da6e76d
It helps if you actually call the methods you write
smashwilson May 10, 2019
25c30be
Broaden the keymap selector used to bind github:submit-comment
smashwilson May 10, 2019
fcf00be
Include lastEditedAt in mutation responses
smashwilson May 10, 2019
d0ead43
Populate missing GraphQL builder fields
smashwilson May 10, 2019
6208572
Add missing props to Reviews(Controller|Container) tests
smashwilson May 10, 2019
ae196b7
Define builders for added mutations
smashwilson May 10, 2019
eef4699
Unit tests for added ReviewsController action methods
smashwilson May 10, 2019
2c5aaad
Update ReviewsController action method behavior to match the tests
smashwilson May 10, 2019
22a08c6
Test coverage for that last branch
smashwilson May 10, 2019
aebdbe7
Pluggable Menu and MenuItem creation
smashwilson May 10, 2019
a6de7c1
The Story So Far
smashwilson May 10, 2019
7ec01ea
fill in actionable-review-view tests
vanessayuenn May 13, 2019
16664b4
:fire: `.only`
vanessayuenn May 13, 2019
66bd0c0
Merge branch 'master' of github.com:atom/github into ku-edit-comments
smashwilson May 13, 2019
1b62553
Use renderMarkdown helper in comment update mutations
smashwilson May 13, 2019
df060f0
Include viewerCan(React|Update) in optimistic and real mutation respo…
smashwilson May 13, 2019
191b1d5
ReviewCommentView tests
smashwilson May 13, 2019
b6e251f
fix the summary related tests and remove the comment ones
vanessayuenn May 13, 2019
c0e14ce
Merge branch 'master' into ku-edit-comments
kuychaco May 14, 2019
9300c71
Finish converting `reportMutationErrors` to `reportRelayError`
kuychaco May 14, 2019
8e4b08f
Update lib/views/review-comment-view.js
kuychaco May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions keymaps/git.cson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,9 @@
'ctrl-=': 'github:more-context'
'ctrl--': 'github:less-context'

'.platform-darwin .github-Review-reply atom-text-editor':
'.platform-darwin .github-Reviews atom-text-editor':
'cmd-enter': 'github:submit-comment'
'.platform-win32 .github-Review-reply atom-text-editor':
'.platform-win32 .github-Reviews atom-text-editor':
'ctrl-enter': 'github:submit-comment'
'.platform-linux .github-Review-reply atom-text-editor':
'.platform-linux .github-Reviews atom-text-editor':
'ctrl-enter': 'github:submit-comment'
86 changes: 54 additions & 32 deletions lib/containers/__generated__/aggregatedReviewsContainerRefetchQuery.graphql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading