Fix: wrong prefix on PR files changed #1855
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
- Coverage 91.15% 91.14% -0.02%
==========================================
Files 196 196
Lines 10744 10745 +1
Branches 1575 1575
==========================================
- Hits 9794 9793 -1
- Misses 950 952 +2
Continue to review full report at Codecov.
|
annthurium
left a comment
annthurium
left a comment
There was a problem hiding this comment.
Thanks @vanessayuenn for fixing!
Left one question, but it's non blocking.
|
|
||
| buildPatch(rawDiff) { | ||
| const diffs = parseDiff(rawDiff); | ||
| const diffs = parseDiff(rawDiff).map(diff => { |
There was a problem hiding this comment.
do we also need to worry about where we're using parseDiff in git-shell-out-strategy? If so, we should consider extracting this functionality to some kind of helper.
I seem to remember some chatter that git gives us different output than the REST api does, so this might not actually be a problem.
There was a problem hiding this comment.
I seem to remember some chatter that git gives us different output than the REST api does,
Indeed! It is a git diff default behaviour to use a/ to prefix the source file and b/ to prefix the destination file. In git-shell-out-strategy, we work around this by using --no-prefix flag to get diffs, but for changed files tab, we don't have that option since we're getting the diff from the REST API.
fixes #1853