This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Pin codecov package to the lastest master #1845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Upgrade the codecov package to the lastest commit on master to take advantage of codecov/codecov-node#114, which should report additional build metadata (like the PR number) from Azure DevOps builds. I'm hopeful that this will make the coverage report a bit more useful.
Alternate Designs
I could also fork the package and publish it under
@smashwilsonlike I did for the test runner. This is slightly less effort though, and this way Greenkeeper will let us know when the next upstream release happens.Benefits
Poking around the CodeCov UI, it looks like coverage reports submitted as pull requests have slightly different functionality than the builds we've been seeing:
I'm particularly intrigued by the "changes" tab there.
I bet this will let us re-enable the changes build status for PR builds that I turned off in #1827 (for pull requests). It might also open the way for coverage change comments.
Possible Drawbacks
It'll take slightly longer to install. It's also a bit messy to depend on git SHAs. But hopefully that's temporary.
Applicable Issues
n/a
Metrics
n/a
Tests
If this uploads correctly, I might add tests for something we don't currently cover to see what the coverage deltas look like.
Documentation
n/a
Release Notes
n/a
User Experience Research (Optional)
"Do we, the developers, understand the coverage reports better" 😉