Suppress "Unable to locate git workspace root" error

[Aerijo]

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Disables said error from being logged to the console, unless the option reportCannotLocateWorkspaceError is set.

Alternate Designs

Could be brought under gitDiagnostics, but that seemed to be for straight git operations. Probably still fits better there though.

Benefits

Stops polluting the console with errors that aren't actually errors 99% of the time.

Possible Drawbacks

NA. I guess it was / could be useful for debugging an issue, hence leaving it as a togglable option (defaulted to disabled).

Applicable Issues

My headaches.

Metrics

NA

Tests

NA

Documentation

NA. Possibly could though.

Release Notes

• Suppress "Unable to locate git workspace root" error

User Experience Research (Optional)

[coveralls]

Coverage increased (+0.05%) to 85.617% when pulling 5be7bd6 on Aerijo:master into 6e07816 on atom:master.

[smashwilson]

👍

I guess it was / could be useful for debugging an issue, hence leaving it as a togglable option (defaulted to disabled).

☝️ If you're curious, this was exactly why the console output was introduced in the first place. We had a crazy bug we couldn't reproduce that manifested as a different exception caught by this try ... catch statement, so I logged it. Of course we haven't seen that problem once since this was introduced 😆

[vanessayuenn]

Thanks for the PR!