This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Split GitTabController into an Item, Container, and Controller #1458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first bit of #1436. Split the
GitTabControllerinto three pieces with distinct reponsibilities:GitTabItemimplements the "item protocol".GitTabContainerfetches asynchronous properties from the Repository. It manages the git tab's loading state and default properties.GitTabControlleris left with only the action methods that are passed to the rest of the hierarchy.This should make fetching mentionable users from GraphQL easier because we can do it within the
GitTabContainerand not have yet another layer of "are these props here or not."