Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@smashwilson
Copy link
Contributor

The first bit of #1436. Split the GitTabController into three pieces with distinct reponsibilities:

  • GitTabItem implements the "item protocol".
  • GitTabContainer fetches asynchronous properties from the Repository. It manages the git tab's loading state and default properties.
  • GitTabController is left with only the action methods that are passed to the rest of the hierarchy.

This should make fetching mentionable users from GraphQL easier because we can do it within the GitTabContainer and not have yet another layer of "are these props here or not."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants