This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Non-existent (Ghost) users Pull Requests crash Github tab #2014
Description
Edit by @rsese to add alternate repro steps with a public repository where I found a now 👻-authored PR: atom/command-palette#76
- Clone https://github.com/atom/command-palette
- Toggle the GitHub tab
GitHub: Toggle GitHub Tab(at this point Bye bye coffee lint and use standard command-palette#76 is filtered out and not shown in theOpen pull requestslist) GitHub: Open Issue or Pull Requestand enterhttps://github.com/atom/command-palette/pull/76
The Git and GitHub tabs go blank and I see this error in console:
TypeError: Cannot read property 'url' of null
at BarePullRequestDetailView.render (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4094739)
at Qg (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2426345)
at Og (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2426140)
at Tg (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2429973)
at bi (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2453979)
at ci (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2454363)
at Di (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2461253)
at Yh (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2460633)
at Xh (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2459654)
at qf (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2458525)
at Object.enqueueSetState (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2408169)
at ReactRelayQueryRenderer.E.setState (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:2336882)
at n.handleDataChange (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4329082)
at /Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4514840
at Array.forEach (<anonymous>)
at ReactRelayQueryFetcher._onQueryDataAvailable (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4514813)
at Object.next (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4512609)
at Object.next (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4549167)
at Object.next (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4549167)
at Object.next (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4547953)
at Object.next (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4549167)
at Executor._next (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4727251)
at Object.next (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4725336)
at Object.next (/Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4549167)
at /Applications/Atom Beta.app/Contents/Resources/app/static/<embedded>:14:4551491
at <anonymous>
At this point, you need to reload the window to use the Git and GitHub tabs again.
1.36.0-beta-2 on macOS 10.12.6.
Prerequisites
- Have you tried to reproduce the problem in Safe Mode?
- Have you followed all applicable steps in the debugging guide?
- Have you checked the FAQs on the message board for common solutions?
- Have you checked that your issue isn't already filed?
Description
When a user deletes their account, any open pull requests they created will crash the github tab
Steps to Reproduce
- Create and add a user to a private repository
- Have the user open a pull request
- Delete the user account
- Open github tab
Expected behavior:
Expected the tab to show the pull requests and associate them with 'ghost' the generic Github user that is displayed on the PR within Github's UI.
Actual behavior:
Tab crashes and takes git tab with it
Reproduces how often:
Anytime you open the tab and the pull request remains open
Versions
All
Additional Information
We noticed this in a private repository, but I assume the issue will exist for public repositories as well