Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Message template does not ignore commented lines like Git does #1817

@lee-dohm

Description

@lee-dohm

Prerequisites

Description

Comment lines are included in the commit message upon commit when your ~/.gitmessage file contains commented lines.

Steps to Reproduce

  1. Create a ~/.gitmessage file that contains two blank lines followed by two lines starting with a # character
  2. Execute the command touch test from the command-line inside a Git repository
  3. Launch Atom in Safe Mode
  4. Open the Git panel
  5. Double-click the test file in the Unstaged Changes panel
  6. Type foo in the first line of the Git commit message box
  7. Click "Commit to master"
  8. Go back to the command line and execute git log -1

Expected behavior:

The commit comment text to consist only of foo

Actual behavior:

The commit comment contains foo, the blank line, and the two following commented lines

Reproduces how often:

100%

Versions

Atom    : 1.35.0-nightly2
Electron: 2.0.14
Chrome  : 61.0.3163.100
Node    : 8.9.3

Additional Information

  • I haven't tested other configurations of commented and uncommented lines (such as starting with comments and then having blank lines)
  • My ~/.gitmessage file is symlinked to my dotfiles directory (though I hope that won't make a difference)

Metadata

Metadata

Assignees

Labels

bugpapercutSmall-scope issues and bugs we can use to backfill our sprint plans

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions