Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Dec 30, 2020

Requirements for Contributing a Bug Fix (from template, click to expand)

Identify the Bug

I get an error during npm install due to misformed URLs:

% npm install                 
npm ERR! code ENOLOCAL
npm ERR! Could not install from "node_modules/jasmine-focused/jasmine-node@git+https:/github.com/kevinsawicki/jasmine-node.git#81af4f953a2b7dfb5bde8331c05362a4b464c5ef" as it does not contain a package.json file.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/[user]/.npm/_logs/2020-12-30T23_38_03_316Z-debug.log

Description of the Change

Update some URLs in package-lock.json that got recorded strangely at some point.

These invalid URLs have the package name prepended. But a valid URL in this case starts with the protocol (git+https://) not the package name (jasmine-node).

-        "jasmine-node": "jasmine-node@git+https://github.com/kevinsawicki/jasmine-node.git#81af4f953a2b7dfb5bde8331c05362a4b464c5ef",
+        "jasmine-node": "git+https://github.com/kevinsawicki/jasmine-node.git#81af4f953a2b7dfb5bde8331c05362a4b464c5ef",

(Git history detective work: Looks like these URLs were unknowingly changed to this strange format in an unrelated PR: #97. For what it's worth, I saw this error before in the apm repo: atom/apm#875 (comment) and used the same fix.)

Alternate Designs

Just delete package-lock.json and run npm install to generate a totally fresh lockfile, as was done in #104.

Possible Drawbacks

None.

Verification Process

npm install succeeds now on my computer. CI should pass.

Release Notes

N/A

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Dec 31, 2020

This fix is now included in #104.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant