This repository was archived by the owner on Dec 15, 2022. It is now read-only.
package-lock.json: Fix misformed URLs #105
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix (from template, click to expand)
Identify the Bug
I get an error during
npm install
due to misformed URLs:Description of the Change
Update some URLs in
package-lock.json
that got recorded strangely at some point.These invalid URLs have the package name prepended. But a valid URL in this case starts with the protocol (
git+https://
) not the package name (jasmine-node
).(Git history detective work: Looks like these URLs were unknowingly changed to this strange format in an unrelated PR: #97. For what it's worth, I saw this error before in the apm repo: atom/apm#875 (comment) and used the same fix.)
Alternate Designs
Just delete
package-lock.json
and runnpm install
to generate a totally fresh lockfile, as was done in #104.Possible Drawbacks
None.
Verification Process
npm install
succeeds now on my computer. CI should pass.Release Notes
N/A