This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Decaffeinate lib/project/results-model #948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Change
lib/project/results-model.coffeetolib/project/results-model.jsusing decaffeinate and some human linting.Alternate Designs
We could leave it as .coffee, but this comment suggests things are moving to ES6, and I would work on this file if it was in Javascript.
I could save this translation as part of a feature PR, but I thought it was useful to make translation a PR of it's own so that the changes on top of that will be easy to track.
Benefits
People don't have to figure out coffeescript to contribute.
Possible Drawbacks
You can't use coffeescript for this file anymore
Applicable Issues
I might add function-replace for project as in issue #417 if I can use es6 Javascript.