Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@jonathan-dejong
Copy link

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Simply added the Find prev button back into the find and replace view.

Alternate Designs

No other alternate designs. People want the button.

Benefits

A new button called "Find prev" will be added before the Find button.

Possible Drawbacks

A change in UI that might stump people used to having the "Find" button first. I added the "Find prev" button before because it's the logical location.

Applicable Issues

None.

@Evpok
Copy link

Evpok commented Jun 11, 2017

If you need evidence-based motivation to merge this, see #453 (comment)

@winstliu
Copy link
Contributor

There's a few indentation inconsistencies with the rest of the file - please sort that out.

Also, can you please upload a picture of what the find panel looks like with the Find Previous button?

@jonathan-dejong
Copy link
Author

jonathan-dejong commented Jun 13, 2017

I've added replace prev button since this too. I'll try and push up the new button as well + fixes for indentation.

Here's what both buttons look like in my theme Atom Material (with a little bit custom CSS for borders around all buttons).
skarmavbild 2017-06-13 kl 09 13 07

EDIT:
Perhaps "Replace prev" should be located before "Replace" ?

@Evpok
Copy link

Evpok commented Jan 16, 2018

Any news on this @jonathan-dejong, @50Wliu ?

@jonathan-dejong
Copy link
Author

@Evpok I'm currently on paternity leave with no time to do anything more.
Honestly I can't remember if I fixed the indentation inconsistencies but really that should be easily fixed by the actual maintainer of the package.

@arthurtaras
Copy link

I'd like to see this feature implemented. It would definitely speed up my workflow.

@ghost
Copy link

ghost commented Dec 11, 2018

I'm not sure why this was ever removed, it was very important to my workflow.

@arthurtaras
Copy link

in current version Shift + Find finds previous. I found it by accident, by the way. I wonder if it is documented somewhere

@ghost
Copy link

ghost commented Dec 11, 2018

in current version Shift + Find finds previous. I found it by accident, by the way. I wonder if it is documented somewhere

Thanks for letting me know. I don't see any mention of this feature on https://atom.io/packages/find-and-replace or https://flight-manual.atom.io/using-atom/sections/find-and-replace/

And it's not in the plugin settings either. It does seem that Shift+Clicking Find to find previous is a completely undocumented feature. It would be nice if a middle mouse button click did it too.

I'd still prefer its own button though, there's certainly space down there.

@UziTech
Copy link
Contributor

UziTech commented Jan 7, 2021

@sadick254 this should be closed based on #1112 (comment)

@sadick254
Copy link
Contributor

Closing based on this comment

@sadick254 sadick254 closed this Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants