This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Understand observeEmbeddedTextEditor to follow embedded TextEditor changes #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smashwilson
changed the title
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This is a follow-on enhancement to #1068. If the active pane item implements
observeEmbeddedTextEditor, the find model will track changes to the embedded TextEditor after the pane item activation completes.Alternate Designs
N/A
Benefits
atom/github will be able to use this API with React refs, which aren't available synchronously on item activation (oops).
Possible Drawbacks
N/A
Applicable Issues
N/A