Find and Replace in large buffer is very slow

[benogle]

From @ypresto on January 21, 2016 7:59

It seems to rebuilding tokenized buffer on every operation in transaction.

It took 16 secs to replace 920 \ns to newline on 15-inch MacBook Pro Retina Late-2013.

Copied from original issue: atom/atom#10531

[benogle]

This is actively being worked on by allowing multiple updates to update the interface and any listeners once. iirc, we do not have an issue to link to at this time. @nathansobo are there any issues related to this?

[lllShamanlll]

Are there any movements here? Didn't find any related atom issue.

[nathansobo]

There was improvement following the issue, but it's always a tricky issue to discuss when performance is "good enough" to close an issue. My answer is that it probably still isn't good enough and we're focusing on some other areas for now. We will revisit find and replace performance in the future.

[nathansobo]

That said, if you'd like to post profile data on any performance issue it is always welcome.

[lllShamanlll]

Actually this looks like atom issue. Due to lack of methods to work with multiple selections, it requires to add selections one by one(what find-and-replace does) & as far as merge performs on every addition, that cause O(N^3) complexity to select-all, where N - count of selections.

So now it takes about 30sec. to select all new-lines in file, that contain 1000 empty lines.
Is that "good enough"? In SBT3 it takes less than a second for instance.

[nathansobo]

It's definitely not good enough, though opening a specific issue addressing select-all-occurrences and posting your saved timeline data would be helpful. We have some challenges due to the synchronous nature of Atom's editor APIs. We need to process selections in a batched manner.

[matthew-dean]

This is still a severe issue on version 1.12.7 of Atom and 0.202.2 of find-and-replace. I would replace "not good enough" with "probably the worst large file loading and searching of any JS-based editor". https://github.com/ajaxorg/ace handles large files, loading and searching, very smoothly.

[jpike88]

Pretty awful. Switched from Sublime Text to this and it freezes up on a medium-large javascript file.

[caleyshemc]

+1, having this issue doing search and replace on large HTML files.

[kingjr]

+1, having same issue on small CSV file