This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Use acorn for JS parsing #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows electron-link to handle code with ecmaScipt 9th edition features.
Contributor
Author
|
Edit: There's an error when using this modified version 😟 Don't know why the whole |
smashwilson
suggested changes
Apr 25, 2019
Contributor
smashwilson
left a comment
smashwilson
left a comment
There was a problem hiding this comment.
One nit, then this should be good to go.
Co-Authored-By: rafeca <[email protected]>
By default, `recast` sets it to `module` (even if `acorn` has it set as `script`). This causes parsing issues since all files are treated in strict mode.
Contributor
Author
|
The previous This caused issues with some non-strict JS files that were parsed as strict and lead to syntax errors. |
This was referenced Oct 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to land an upgrade of the
markdown-previewpackage, we realized thatelectron-linkdoes not support some modern JS syntax features. This was due to theesprimaparser which is quite old.To solve this, I've changed the
esprimaconfiguration to useacornas a parser, specifying that we want to support the 9th edition syntax features.Verification process
electron-linkversion used in ⬆️ [email protected] atom#19209 and check that the build passes