Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Conversation

@smashwilson
Copy link
Contributor

Update atom/github on the beta channel to include atom/github#1847 in the next stable release.

@smashwilson
Copy link
Contributor Author

Code-signing executable at C:\projects\atom\out\Atom Beta x64\Atom.exe
SignTool Error: The specified PFX password is not correct.
Error: Command C:\projects\atom\script\node_modules\electron-winstaller\vendor\signtool.exe sign /f C:\Users\appveyor\AppData\Local\Temp\1\win.p12 /p ****** /fd sha256 /tr http://timestamp.digicert.com /td sha256 "C:\projects\atom\out\Atom Beta x64\Atom.exe" exited with code 1
  at signFile (C:\projects\atom\script\lib\code-sign-on-windows.js:43:13)
  at module.exports (C:\projects\atom\script\lib\code-sign-on-windows.js:21:7)
  at binariesPromise.then.then.then.packagedAppPath (C:\projects\atom\script\build:100:13)
  at <anonymous>:null:null
Command exited with code 1

@daviwil are we supposed to be trying to code-sign executables in PR builds... ?

@daviwil
Copy link
Contributor

daviwil commented Dec 18, 2018

I believe that since you're PR'ing into a release branch, the AppVeyor automation decided to make a signed release build. We had to roll the Windows signing certs recently, let me see if the password got broken there.

@daviwil
Copy link
Contributor

daviwil commented Dec 19, 2018

Kicked off an Azure Pipelines build for final verification, once that passes I'll merge this!

https://github.visualstudio.com/Atom/_build/results?buildId=26392

@daviwil
Copy link
Contributor

daviwil commented Dec 19, 2018

Good to go!

@daviwil daviwil merged commit 1804438 into 1.34-releases Dec 19, 2018
@daviwil daviwil deleted the aw/github-up-beta branch December 19, 2018 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants