Splitting tree-view in dock creates empty pane in docks

[ungb]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Splitting tree-view in dock splits empty pane

Steps to Reproduce

1. Open a project in atom-beta
2. on the tree-view, split the item, left, right, top, and bottom

Expected behavior: [What you expect to happen]
It should probably no-op as it is splitting empty items

Actual behavior: [What actually happens]
it creates a bunch of empty panes in the dock.

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Versions

Atom : 1.17.0-beta1
Electron: 1.3.14
Chrome : 52.0.2743.82
Node : 6.5.0
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

[winstliu]

I actually get Uncaught (in promise) Error: The workspace can only contain one instance of item [object Object] when attempting to split, which then totally explodes my Atom instance. Had to clear window state to get it to start again.

[ungb]

@50Wliu, glad it's not just me. I was going to comment on the same thing. I saw this too, but I couldn't consistently repro it.

There's a few bugs related to that issue. like this one: atom/tabs#234 the one error message linked to

[Ben3eeE]

I actually get Uncaught (in promise) Error: The workspace can only contain one instance of item [object Object] when attempting to split, which then totally explodes my Atom instance. Had to clear window state to get it to start again.

This happens if you right click on the tab of the tree-view and split. I didn't see it when splitting with other steps.

[as-cii]

Thanks for the report, @ungb. I wanted to start looking into this but unfortunately I am unable to reproduce the issue:

• Right-clicking on a tab and splitting has no effect.
• Invoking pane:split-right-and-copy-active-item creates a new pane, but does not duplicate the tree-view item. This is consistent with what happens when you attempt to split a non-copyable item in the center dock. Maybe it could be slightly confusing but it does not seem to be a bug.
• Invoking pane:split-right correctly creates a new pane.

None of the cases above triggered an exception and I could close the mistakenly opened panes quite easily. Also, I think splitting panes in docks is a quite useful behavior, as it allows to move other dock items (like the Git pane) into the same dock:

Given that I can't reproduce the exception and the behavior isn't necessarily confusing, I would propose to go ahead and close this. What do you think @ungb @50Wliu @Ben3eeE?

[Ben3eeE]

@as-cii I can no longer reproduce the exception by following the same steps as I did before. Maybe fixed by atom/tabs#522?

I think that we should close this.

[as-cii]

Thanks for confirming, @Ben3eeE!

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!