Skip to content

chore: add Eslint to the project + strict JavaScript + fix issues #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 4, 2022
Merged

chore: add Eslint to the project + strict JavaScript + fix issues #5

merged 9 commits into from
Jul 4, 2022

Conversation

@aminya
Copy link
Member

@aminya aminya commented Jul 3, 2022 •
edited
Loading

  • Having static checks is extremely important. This prevents bugs like fix: Remove extra paren #3
  • This also fixes some issues with the loose usage of JavaScript.
  • Some automatic fixes by Eslint
  • Uses pnpm to install the project during development
  • use named import/export for results-model

Allows using Babel 7 atom-community/atom#67

@aminya aminya mentioned this pull request Jul 3, 2022
Open
@aminya aminya merged commit 9252e77 into master Jul 4, 2022
@aminya aminya mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aminya