Skip to content

Conversation

@mertmit
Copy link
Contributor

@mertmit mertmit commented Feb 14, 2025

Our processes started hanging suddenly throwing port in use error on code changes (graceful restart)
I found out recent update introduced a bug which checks optional parameter and prevents killing the process.

Ref: nocodb/nocodb#10507

This was hard to debug, so I would recommend publishing this when possible.

@atassis atassis merged commit 9ac34d0 into atassis:main Feb 23, 2025
@atassis
Copy link
Owner

atassis commented Feb 23, 2025

Sorry for the inconvenience, version 0.2.2 is published with the patch.
I have nothing to test this on, can you double check that npm version is working?

@sergiupris
Copy link
Contributor

sergiupris commented Mar 27, 2025

@mertmit in this case it's not working as intended using signal: false
In your case using autoRestart you could simply add signal - true:

        autoRestart: true,
        signal: true,

Now, signal false will have no benefit and we always do a restart. Having autoRestart: false will break HMR e.g https://docs.nestjs.com/recipes/hot-reload#configuration is no longer valid documentation (not working)

@atassis

@mertmit
Copy link
Contributor Author

mertmit commented Mar 27, 2025

@sergiupris
I think culprit here is not the signal but extra _stopServer call (line 72) regardless of autoRestart (asking for extra property signal to allow default behavior wouldn't make sense imo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants