Support S3::PutPublicAccessBlock

[shadowhand]

No description provided.

[shadowhand]

Obviously there are some things that need to be fixed in the tests, but I don't know where to start or how to properly run the tests locally. When I try to run make test it does a lot of stuff and then terminates with:

PHP Fatal error:  Declaration of PHPUnit\Framework\TestSuite::run(): void must be compatible with PHPUnit\Framework\Test::run(?PHPUnit\Framework\TestResult $result = null): PHPUnit\Framework\TestResult in /Users/woodygilk/Code/async-aws/aws/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 332

Fatal error: Declaration of PHPUnit\Framework\TestSuite::run(): void must be compatible with PHPUnit\Framework\Test::run(?PHPUnit\Framework\TestResult $result = null): PHPUnit\Framework\TestResult in /Users/woodygilk/Code/async-aws/aws/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 332
make: *** [test] Error 255

[stof]

how are you running PHPUnit ? Have you installed latest dependencies in your local setup ? And is this based on an uptodate state of the master branch ?

[shadowhand]

@stof make test. Yes, I have run composer install. Yes, this is from master branch.

[stof]

In case you have your local setup since quite some times, run composer update instead of composer install (composer install would reinstall what you have in your local composer.lock file from the last time you updated vendors)

[stof]

I found the issue with our local setup and I submitted a PR to fix it.

[stof]

@shadowhand the issue with make test is now fixed in the latest master branch.

[stof]

this change is wrong. This requirement is managed by the code generator. Please make sure that you ran the latest version of the code generator (rather than running an old version and then rebasing the generated code)

[shadowhand]

FYI, the code generator is what changed this. I have not modified the generator in any way.