TST: Update matrix #174
TST: Update matrix #174
Conversation
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 27 27
Lines 1146 1146
=======================================
Hits 1030 1030
Misses 116 116 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Looks good. We may need to double check that the oldest version is indeed properly picked up (it's a bit concerning that it wasn't the case previously yet we got a big green checkmark)
|
Maybe also add a py312 to the dev testing? (or maybe add that separately as it may require some fixes first) |
|
I can try add 3.12 but if it fails for reasons we cannot control, I'll take it back out. |
and update RTD config
TST: Install setuptools for tests in Python 3.12
pllim
force-pushed
the
update-ci-matrix
branch
from
b973381 to
680bf31
Compare
| pytest-cov | ||
| cython | ||
| coverage | ||
| setuptools;python_version>='3.12' |
There was a problem hiding this comment.
@bsipocz , I needed this for the Python 3.12-dev job to pass. Does this look right or is this a symptom of something else?
|
Anyway, why don't we merge this as-is. And we can revisit Python 3.12 job if what I did here isn't the way to go. Thanks! |
2 participants
Close #173 by updating matrix. The compatibility was already addressed in #172 .