BUG: fixing parsing special object names for skybot #3307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
force-pushed
the
MAINT_skybot_votable
branch
from
ec0a366 to
d3e3034
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3307 +/- ##
==========================================
- Coverage 69.88% 69.87% -0.01%
==========================================
Files 232 232
Lines 19742 19742
==========================================
- Hits 13796 13795 -1
- Misses 5946 5947 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mkelley
approved these changes
May 2, 2025
Contributor
mkelley
left a comment
mkelley
left a comment
There was a problem hiding this comment.
This all looks good, except the added columns '_raj2000', '_decj2000', and 'externallink' affect the example table output in the documentation.
Currently:
>>> results.pprint(max_width=80)
Number Name RA ... vy vz epoch
deg ... AU / d AU / d d
------ ---------- -------------------- ... ----------- ----------- ---------
-- 2012 BO42 0.019414999999999998 ... 0.009345668 0.005003011 2458630.0
516566 2007 DH36 0.005546249999999999 ... 0.00855646 0.002875928 2458630.0
-- 2019 SS82 359.9931945833333 ... 0.009809784 0.004636687 2458630.0
163149 2002 CV106 359.98692374999996 ... 0.009078104 0.00267749 2458630.0This PR:
>>> results.pprint(max_width=80)
Number ... externallink
...
------ ... ---------------------------------------------------------------
-- ... https://ssp.imcce.fr/webservices/ssodnet/api/ssocard/2012_BO42
516566 ... https://ssp.imcce.fr/webservices/ssodnet/api/ssocard/2007_DH36
659626 ... https://ssp.imcce.fr/webservices/ssodnet/api/ssocard/2019_SS82
-- ... https://ssp.imcce.fr/webservices/ssodnet/api/ssocard/2019_SH196
163149 ... https://ssp.imcce.fr/webservices/ssodnet/api/ssocard/2002_CV106Potential fix?
>>> results["Number", "Name", "RA", "DEC", "Type"]
Number Name RA DEC Type
deg deg
------ ---------- -------------------- --------------------- ---------
-- 2012 BO42 0.019139999999999997 -0.01297 MB>Middle
516566 2007 DH36 0.005300833333333333 0.02301111111111111 MB>Inner
659626 2019 SS82 359.99291625 -0.028969444444444443 MB>Inner
-- 2019 SH196 359.96022083333327 -0.030131944444444444 MB>Inner
163149 2002 CV106 359.9866720833333 -0.06932138888888889 MB>Inner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to use votable responses so special characters in object names can be parsed without problems.
I have also switched to return
NoResultsWarninginstead ofRuntimeErrorsforFix #3301
cc @mkelley - it would be great if you could review this