Skip to content

Stabilize unnecessary-round (RUF057) #18563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

Stabilize unnecessary-round (RUF057) #18563

merged 2 commits into from
Jun 9, 2025

Conversation

@dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Jun 8, 2025

No description provided.

@dylwil3 dylwil3 added this to the v0.12 milestone Jun 8, 2025
@dylwil3 dylwil3 added the rule Implementing or modifying a lint rule label Jun 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+152 -4 violations, +0 -0 fixes in 16 projects; 39 projects unchanged)

DisnakeDev/disnake (+15 -0 violations, +0 -0 fixes) 

+ disnake/app_commands.py:1213:7: PLW1641 Object does not implement `__hash__` method
+ disnake/app_commands.py:162:7: PLW1641 Object does not implement `__hash__` method
+ disnake/app_commands.py:469:7: PLW1641 Object does not implement `__hash__` method
+ disnake/app_commands.py:95:7: PLW1641 Object does not implement `__hash__` method
+ disnake/app_commands.py:993:7: PLW1641 Object does not implement `__hash__` method
+ disnake/embeds.py:112:7: PLW1641 Object does not implement `__hash__` method
+ disnake/embeds.py:43:7: PLW1641 Object does not implement `__hash__` method
+ disnake/enums.py:97:7: PLW1641 Object does not implement `__hash__` method
+ disnake/flags.py:54:7: PLW1641 Object does not implement `__hash__` method
+ disnake/i18n.py:172:7: PLW1641 Object does not implement `__hash__` method
... 5 additional changes omitted for project

PlasmaPy/PlasmaPy (+5 -0 violations, +0 -0 fixes) 

+ src/plasmapy/analysis/nullpoint.py:108:7: PLW1641 Object does not implement `__hash__` method
+ src/plasmapy/formulary/relativity.py:191:7: PLW1641 Object does not implement `__hash__` method
+ src/plasmapy/particles/ionization_state.py:169:7: PLW1641 Object does not implement `__hash__` method
+ src/plasmapy/particles/ionization_state.py:32:7: PLW1641 Object does not implement `__hash__` method
+ src/plasmapy/particles/ionization_state_collection.py:32:7: PLW1641 Object does not implement `__hash__` method

apache/airflow (+36 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ airflow-core/src/airflow/models/taskinstance.py:2518:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/src/airflow/task/priority_strategy.py:29:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/src/airflow/timetables/_cron.py:63:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/src/airflow/timetables/interval.py:176:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/src/airflow/timetables/simple.py:33:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/src/airflow/utils/db.py:1461:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/src/airflow/utils/operator_resources.py:112:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/src/airflow/utils/operator_resources.py:31:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/tests/unit/models/test_baseoperator.py:44:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/tests/unit/models/test_renderedtifields.py:52:7: PLW1641 Object does not implement `__hash__` method
+ airflow-core/tests/unit/serialization/test_dag_serialization.py:1237:11: PLW1641 Object does not implement `__hash__` method
... 25 additional changes omitted for project

apache/superset (+4 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ RELEASING/changelog.py:39:7: PLW1641 Object does not implement `__hash__` method
+ superset/migrations/shared/security_converge.py:57:7: PLW1641 Object does not implement `__hash__` method
+ superset/migrations/versions/2020-09-24_12-04_3fbbc6e8d654_fix_data_access_permissions_for_virtual_.py:57:7: PLW1641 Object does not implement `__hash__` method
+ superset/sql/parse.py:273:7: PLW1641 Object does not implement `__hash__` method

aws/aws-sam-cli (+14 -0 violations, +0 -0 fixes) 

+ samcli/lib/build/build_graph.py:515:7: PLW1641 Object does not implement `__hash__` method
+ samcli/lib/build/build_graph.py:579:7: PLW1641 Object does not implement `__hash__` method
+ samcli/lib/observability/cw_logs/cw_log_event.py:10:7: PLW1641 Object does not implement `__hash__` method
+ samcli/lib/providers/provider.py:182:7: PLW1641 Object does not implement `__hash__` method
+ samcli/lib/providers/provider.py:214:7: PLW1641 Object does not implement `__hash__` method
+ samcli/lib/providers/provider.py:574:7: PLW1641 Object does not implement `__hash__` method
+ samcli/lib/telemetry/event.py:95:7: PLW1641 Object does not implement `__hash__` method
+ samcli/local/apigw/authorizers/lambda_authorizer.py:187:7: PLW1641 Object does not implement `__hash__` method
+ samcli/local/apigw/authorizers/lambda_authorizer.py:29:7: PLW1641 Object does not implement `__hash__` method
+ samcli/local/lambdafn/config.py:10:7: PLW1641 Object does not implement `__hash__` method
... 4 additional changes omitted for project

bokeh/bokeh (+4 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ src/bokeh/core/property/bases.py:442:7: PLW1641 Object does not implement `__hash__` method
+ src/bokeh/core/property/bases.py:84:7: PLW1641 Object does not implement `__hash__` method
+ src/bokeh/core/property/struct.py:49:7: PLW1641 Object does not implement `__hash__` method
+ src/bokeh/embed/util.py:184:7: PLW1641 Object does not implement `__hash__` method

freedomofpress/securedrop (+1 -0 violations, +0 -0 fixes) 

+ securedrop/models.py:312:7: PLW1641 Object does not implement `__hash__` method

ibis-project/ibis (+18 -0 violations, +0 -0 fixes) 

+ ibis/common/bases.py:132:7: PLW1641 Object does not implement `__hash__` method
+ ibis/common/bases.py:184:7: PLW1641 Object does not implement `__hash__` method
+ ibis/common/collections.py:119:7: PLW1641 Object does not implement `__hash__` method
+ ibis/common/deferred.py:16:7: PLW1641 Object does not implement `__hash__` method
+ ibis/common/deferred.py:59:7: PLW1641 Object does not implement `__hash__` method
+ ibis/common/egraph.py:16:7: PLW1641 Object does not implement `__hash__` method
+ ibis/common/grounds.py:101:7: PLW1641 Object does not implement `__hash__` method
+ ibis/common/patterns.py:63:7: PLW1641 Object does not implement `__hash__` method
+ ibis/common/tests/test_deferred.py:231:7: PLW1641 Object does not implement `__hash__` method
+ ibis/common/tests/test_patterns.py:1153:7: PLW1641 Object does not implement `__hash__` method
... 8 additional changes omitted for project

langchain-ai/langchain (+9 -0 violations, +0 -0 fixes) 

+ libs/core/langchain_core/outputs/llm_result.py:15:7: PLW1641 Object does not implement `__hash__` method
+ libs/core/langchain_core/runnables/base.py:3986:7: PLW1641 Object does not implement `__hash__` method
+ libs/core/langchain_core/runnables/base.py:4284:7: PLW1641 Object does not implement `__hash__` method
+ libs/core/langchain_core/tracers/log_stream.py:134:7: PLW1641 Object does not implement `__hash__` method
+ libs/core/langchain_core/tracers/log_stream.py:94:7: PLW1641 Object does not implement `__hash__` method
+ libs/core/tests/unit_tests/load/test_serializable.py:95:11: PLW1641 Object does not implement `__hash__` method
+ libs/core/tests/unit_tests/load/test_serializable.py:9:7: PLW1641 Object does not implement `__hash__` method
+ libs/core/tests/unit_tests/stubs.py:7:7: PLW1641 Object does not implement `__hash__` method
+ libs/core/tests/unit_tests/test_tools.py:2379:11: PLW1641 Object does not implement `__hash__` method

milvus-io/pymilvus (+6 -0 violations, +0 -0 fixes) 

+ pymilvus/client/types.py:31:7: PLW1641 Object does not implement `__hash__` method
+ pymilvus/milvus_client/index.py:4:7: PLW1641 Object does not implement `__hash__` method
+ pymilvus/orm/index.py:23:7: PLW1641 Object does not implement `__hash__` method
+ pymilvus/orm/schema.py:375:7: PLW1641 Object does not implement `__hash__` method
+ pymilvus/orm/schema.py:561:7: PLW1641 Object does not implement `__hash__` method
+ pymilvus/orm/schema.py:90:7: PLW1641 Object does not implement `__hash__` method

pypa/cibuildwheel (+2 -0 violations, +0 -0 fixes) 

+ cibuildwheel/environment.py:76:7: PLW1641 Object does not implement `__hash__` method
+ cibuildwheel/util/helpers.py:144:7: PLW1641 Object does not implement `__hash__` method

rotki/rotki (+0 -4 violations, +0 -0 fixes) 

- rotkehlchen/chain/arbitrum_one/types.py:9:48: RUF100 [*] Unused `noqa` directive (non-enabled: `PLW1641`)
- rotkehlchen/chain/evm/l2_with_l1_fees/types.py:24:49: RUF100 [*] Unused `noqa` directive (non-enabled: `PLW1641`)
- rotkehlchen/history/events/structures/eth2.py:459:52: RUF100 [*] Unused `noqa` directive (non-enabled: `PLW1641`)
- rotkehlchen/history/events/structures/eth2.py:75:48: RUF100 [*] Unused `noqa` directive (non-enabled: `PLW1641`)

zulip/zulip (+3 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ zerver/lib/push_notifications.py:98:7: PLW1641 Object does not implement `__hash__` method
+ zerver/lib/thumbnail.py:34:7: PLW1641 Object does not implement `__hash__` method
+ zerver/lib/validator.py:573:7: PLW1641 Object does not implement `__hash__` method

wntrblm/nox (+1 -0 violations, +0 -0 fixes) 

+ nox/_parametrize.py:31:7: PLW1641 Object does not implement `__hash__` method

pytest-dev/pytest (+7 -0 violations, +0 -0 fixes) 

+ src/_pytest/python_api.py:125:7: PLW1641 Object does not implement `__hash__` method
+ src/_pytest/python_api.py:229:7: PLW1641 Object does not implement `__hash__` method
+ src/_pytest/python_api.py:305:7: PLW1641 Object does not implement `__hash__` method
+ testing/code/test_excinfo.py:1689:11: PLW1641 Object does not implement `__hash__` method
+ testing/example_scripts/dataclasses/test_compare_dataclasses_with_custom_eq.py:9:11: PLW1641 Object does not implement `__hash__` method
+ testing/test_assertion.py:1188:15: PLW1641 Object does not implement `__hash__` method
+ testing/test_assertion.py:1202:15: PLW1641 Object does not implement `__hash__` method

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
PLW1641 152 152 0 0 0
RUF100 4 0 4 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre force-pushed the brent/release-0.12.0 branch from 0370d8a to 040fb6b Compare June 8, 2025 19:55
@ntBre ntBre requested a review from AlexWaygood as a code owner June 8, 2025 19:55
@ntBre ntBre force-pushed the brent/release-0.12.0 branch from 040fb6b to 9252447 Compare June 8, 2025 20:18
@AlexWaygood AlexWaygood removed their request for review June 8, 2025 20:28
@ntBre ntBre force-pushed the brent/release-0.12.0 branch from 9252447 to 829acf4 Compare June 9, 2025 00:22
@dylwil3 dylwil3 force-pushed the dylan/stabilize-ruf057 branch from 71f80ce to 98a3bc7 Compare June 9, 2025 13:04
ntBre
ntBre approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one has its test_case on a preview_rules function still.

@dylwil3 dylwil3 merged commit 5dcff13 into brent/release-0.12.0 Jun 9, 2025
34 checks passed
@dylwil3 dylwil3 deleted the dylan/stabilize-ruf057 branch June 9, 2025 19:00
@dylwil3 dylwil3 mentioned this pull request Jun 9, 2025
Merged
2 tasks
ntBre pushed a commit that referenced this pull request Jun 10, 2025
@dylwil3 @ntBre
Stabilize unnecessary-round (RUF057) (#18563)
58fb44e
ntBre pushed a commit that referenced this pull request Jun 11, 2025
@dylwil3 @ntBre
Stabilize unnecessary-round (RUF057) (#18563)
341b61c
ntBre pushed a commit that referenced this pull request Jun 11, 2025
@dylwil3 @ntBre
Stabilize unnecessary-round (RUF057) (#18563)
bcf0b2d
ntBre pushed a commit that referenced this pull request Jun 16, 2025
@dylwil3 @ntBre
Stabilize unnecessary-round (RUF057) (#18563)
200d713
ntBre pushed a commit that referenced this pull request Jun 17, 2025
@dylwil3 @ntBre
Stabilize unnecessary-round (RUF057) (#18563)
42d6655
ntBre pushed a commit that referenced this pull request Jun 17, 2025
@dylwil3 @ntBre
Stabilize unnecessary-round (RUF057) (#18563)
0a1c6cb
carljm added a commit to MatthewMckee4/ruff that referenced this pull request Jun 17, 2025
@carljm
Merge branch 'main' into incorrect-subdiagnostic-for-unresolved-refer…
bef7491 
…ence

* main: (71 commits)
  Bump 0.12.0 (astral-sh#18724)
  Revert "[ty] Offer "Did you mean...?" suggestions for unresolved `from` imports and unresolved attributes (astral-sh#18705)" (astral-sh#18721)
  [`flake8-return`] Stabilize only add `return None` at the end when fixing `implicit-return` (`RET503`) (astral-sh#18516)
  [`pyupgrade`] Stabilize `non-pep695-generic-function` (`UP047`) (astral-sh#18524)
  [`pyupgrade`] Stabilize `non-pep695-generic-class` (`UP046`) (astral-sh#18519)
  [`pandas-vet`] Deprecate `pandas-df-variable-name` (`PD901`) (astral-sh#18618)
  [`flake8-bandit`] Remove `suspicious-xmle-tree-usage` (`S320`) (astral-sh#18617)
  Stabilize `dataclass-enum` (`RUF049`) (astral-sh#18570)
  Stabilize `unnecessary-dict-index-lookup` (`PLR1733`) (astral-sh#18571)
  Remove rust-toolchain.toml from sdist (astral-sh#17925)
  Stabilize `starmap-zip` (`RUF058`) (astral-sh#18525)
  [`flake8-logging`] Stabilize `exc-info-outside-except-handler` (`LOG014`) (astral-sh#18517)
  [`pyupgrade`] Stabilize `non-pep604-annotation-optional` (`UP045`) and preview behavior for `non-pep604-annotation-union` (`UP007`) (astral-sh#18505)
  Stabilize `pytest-warns-too-broad` (`PT030`) (astral-sh#18568)
  Stabilize `for-loop-writes` (`FURB122`) (astral-sh#18565)
  Stabilize `pytest-warns-with-multiple-statements` (`PT031`) (astral-sh#18569)
  Stabilize `pytest-parameter-with-default-argument` (`PT028`) (astral-sh#18566)
  Stabilize `nan-comparison` (`PLW0177`) (astral-sh#18559)
  Stabilize `check-and-remove-from-set` (`FURB132`) (astral-sh#18560)
  Stabilize `unnecessary-round` (`RUF057`) (astral-sh#18563)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntBre ntBre ntBre approved these changes

Assignees

No one assigned

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Milestone

v0.12

Development

Successfully merging this pull request may close these issues.

3 participants

@dylwil3 @ntBre