This repository was archived by the owner on Dec 18, 2018. It is now read-only.
[JAVA] Added read locks for hub connection states #3335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mikaelm12
reviewed
Nov 27, 2018
Contributor
mikaelm12
left a comment
mikaelm12
left a comment
There was a problem hiding this comment.
Thanks for the pr! Looks pretty good. Our branches are currently locked but I'll keep you updated on that
Contributor
|
Hi @ncthbrt. Thanks again for the PR. I think we found the source of the issue. It isn't a lack of locking on reads but rather not checking the connection state on invokes. We have a new PR here dotnet/aspnetcore#4400. I'm going to go ahead and close this Pr but thanks again for your contribution! We were able to find this bug because of you 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in Issue #3329, reads of the connection state weren't synchronized. This PR adds a
ReentrantReadWriteLocktoHubConnection.java