This repository was archived by the owner on Dec 19, 2018. It is now read-only.
New baselines for CSharpTemplateTest and CSharpVerbatimBlockTest #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrite CSharp parser - Basic rewrite of HTML parser - Define and generate syntax nodes and boilerplate - Rewrite ClassifiedSpan generation logic - Update parser test infrastructure
* Generate baselines for HtmlDocumentTest * Feedback * More feedback * Rename all Html to Markup
* Rewrite WhitespaceRewriter * Rename CSharpExpression to CSharpExplicitExpression
NTaylorMullen
suggested changes
Nov 6, 2018
| SyntaxKind.RightParenthesis;[)]; | ||
| MetaCode span - Gen<None> - [)] - SpanEditHandler;Accepts:None - (36:0,36) - Tokens:1 | ||
| SyntaxKind.RightParenthesis;[)]; | ||
| CSharpCodeBlock - [0..37)::37 - [(Html.Repeat(10, @<p>Foo #@item</p>))] |
There was a problem hiding this comment.
It'd be good to eventually change these tests to run in a format that actually happens in practice. Aka, running them in the context of a document so things like a transition is required to even begin parsing C#
Contributor
Author
There was a problem hiding this comment.
How important is it you think relative to other work? Do you think it's worth filing a bug for this?
Contributor
Author
There was a problem hiding this comment.
Spoke offline. We'll do this if/when we really need it.
| CSharpCodeBlock - [1..10)::9 | ||
| CSharpStatementLiteral - [1..2)::1 - [i] - Gen<Stmt> - AutoCompleteEditHandler;Accepts:Any,AutoComplete:[<null>];AtEOL | ||
| Identifier;[i]; | ||
| CSharpTemplateBlock - [2..10)::8 |
| Whitespace;[ ]; | ||
| Assign;[=]; | ||
| Whitespace;[ ]; | ||
| CSharpTemplateBlock - [12..20)::8 |
There was a problem hiding this comment.
ya template is totally the wrong name.
Contributor
Author
There was a problem hiding this comment.
I agree. I'll add this to the list to discuss in the future
Contributor
Author
There was a problem hiding this comment.
ajaybhargavb
force-pushed
the
feature/razor-parser
branch
from
1ffaefe to
ded13b7
Compare
NTaylorMullen
approved these changes
Nov 9, 2018
Contributor
Author
|
Merged ec5cb34 |
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2698