Correct ValidateStreamForReading(...)
#390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
requested review from
a team,
MackinnonBuck,
Nick-Stanton,
Tratcher,
javiercn and
mkArtakMSFT
Tratcher
reviewed
Feb 23, 2023
Tratcher
reviewed
Feb 23, 2023
Tratcher
approved these changes
Feb 23, 2023
- fix #389 - check `Stream` before first read attempt - check `CanRead` (not `CanSeek`) before second or later read attempts - add lots of tests of related scenarios - nit: correct a recent `HttpContentMessageExtensions` comment
Co-authored-by: Chris Ross <[email protected]>
- `ReadAsStreamAsync()` introduces unwanted behaviours - returned `Stream` cannot be read multiple times and is not recreated on next `ReadAsStreamAsync` call - method buffers the `HttpContent`, invalidating the intent of `unBuffered`
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageHttpContextdoes not handle unreadable/unseekableStreams well #389Streambefore first read attemptCanRead(notCanSeek) before second or later read attemptsHttpContentMessageExtensionscomment