Skip to content

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Dec 12, 2022

  • handle both SDK-style and legacy projects in one way
    • set $(RestorePackagesConfig) to cover both project types
  • allow newer .NET SDKs to align w/ VS components
  • make a few <import/>s conditional to avoid problems in Restore target evaluation
  • restore global packages.config before building to make StyleCop available
  • move second copies of packages.config packages into packages/ folder
  • update FxCop TFM
    • .NET 4.0 not supported because current FxCopSdk is built against .NET 4.7.2
  • suppress new warnings about old FxCop approach and not using IFormatProvider

@dougbu dougbu requested review from a team, MackinnonBuck, TanayParikh and javiercn December 12, 2022 04:18
@dougbu
Copy link
Contributor Author

dougbu commented Dec 12, 2022

This should unblock #371

- handle both SDK-style and legacy projects in one way
  - set `$(RestorePackagesConfig)` to cover both project types
- allow newer .NET SDKs to align w/ VS components
- make a few `<import/>`s conditional to avoid problems in `Restore` target evaluation
- restore global packages.config before building to make StyleCop available
- move second copies of packages.config packages into packages/ folder
- update FxCop TFM
  - .NET 4.0 not supported because current FxCopSdk is built against .NET 4.7.2
- suppress new warnings about old FxCop approach and not using `IFormatProvider`
@dougbu
Copy link
Contributor Author

dougbu commented Dec 12, 2022

Rebased on main to correct conflicts. Should be ready to go…

@dougbu dougbu merged commit c98af89 into aspnet:main Dec 12, 2022
@dougbu dougbu deleted the dougbu/build.with.vs2019 branch December 12, 2022 19:16
@dougbu dougbu added this to the 3.3.0 (5.3.0) milestone Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants