Do not fail tests immediately #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- combine `RegexReplace` into `PrintTestRunSummary` task
- remove unused `WarnOnNoMatch` parameter; inline other parameters
- capture test summary in `msbuild` logs
- avoid `System.Console` use in the task
- fail task if any tests fail
- collect `xunit` task exit codes in case of catastrophic problems (not test failures)
- fail build if `PrintTestRunSummary` doesn't but errors occurred
also:
- do not test assemblies in parallel; reduce port contention issues
- avoid `CallTarget` task
nits:
- clean some trailing whitespace in C# sources
- mostly files I expect to update soon
- reduce `NuGet.exe restore` verbosity; no longer debugging that
- add console summary when using build.cmd
- reduce duplication in `RestorePackages` target
- only restore NetCore projects when `$(BuildPortable)` is `true`
- restore src NetStandard project transitively through NetStandard.Test project
- pass more properties w/ `Restore` target invocation
dougbu
requested review from
a team,
MackinnonBuck,
TanayParikh and
javiercn
dougbu
commented
Nov 23, 2022
| <_NuGetPackagesAndSolutions Include="src\System.Net.Http.Formatting.NetCore\packages.config; | ||
| test\System.Net.Http.Formatting.NetCore.Test\packages.config" | ||
| Condition=" '$(BuildPortable)' == 'true' " /> | ||
| <_ProjectsToRestore Include="src\System.Net.Http.Formatting.NetStandard\System.Net.Http.Formatting.NetStandard.csproj; |
There was a problem hiding this comment.
another nit: this project is restored transitively and it's more reliable not to kick that off at the same time as the test project
TanayParikh
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegexReplaceintoPrintTestRunSummarytaskWarnOnNoMatchparameter; inline other parametersmsbuildlogsSystem.Consoleuse in the taskxunittask exit codes in case of catastrophic problems (not test failures)PrintTestRunSummarydoesn't but errors occurredalso:
CallTargettasknits:
NuGet.exe restoreverbosity; no longer debugging thatRestorePackagestarget$(BuildPortable)istrueRestoretarget invocation