Do not include compiler-generated names in expression names #140
Conversation
- #117 - see also aspnet/Mvc@a045324d3a and PR aspnet/Mvc#3027, the fix for aspnet/Mvc#2890 nits: copy some improved comments from aspnet/Mvc@a045324d3a
|
|
||
| // If identifier contains "__", it is "reserved for use by the implementation" and likely compiler- | ||
| // or Razor-generated e.g. the name of a field in a delegate's generated class. | ||
| if (name.Contains("__")) |
There was a problem hiding this comment.
Would we need a compat switch to allow this? Seems like a super corner case though.
There was a problem hiding this comment.
Presumably Razor doesn't stick a CompilerGeneratedAttribute or something along those lines on the member that we could use to infer this?
There was a problem hiding this comment.
We're already dealing with an infrequent case. Imaging a scenario where this fix causes a problem is pretty extreme. I don't think the slight change is worth a compat switch. But, I'll ask around…
Roslyn does apply [CompilerGenerated] to its generated classes but not to fields in those classes. So, that attribute doesn't help distinguish <>c__DisplayClass3_0.collection (which is fine) from <>c__DisplayClass5_1,CS$<>8__locals1 (which isn't). and __ is what docs say. (See the last paragraph in this section of the language spec for example.)
|
|
2 participants
nits: copy some improved comments from aspnet/Mvc@a045324d3a