Hygiene #113
Merged
Hygiene #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Member
Author
|
Most of the changes are just whitespace... Use the "hide whitespace changes" option for easier viewing. |
kennyp
reviewed
Jul 16, 2023
Member
kennyp
left a comment
kennyp
left a comment
There was a problem hiding this comment.
Overall it looks good, just one question.
Member
There was a problem hiding this comment.
question: Since the install path could contain a space, shouldn't this still be quoted?
Member
Author
There was a problem hiding this comment.
Yes, they normally shouldn't be needed here!
kennyp
approved these changes
Jul 19, 2023
Member
kennyp
left a comment
kennyp
left a comment
There was a problem hiding this comment.
Thanks for the cleanup @smorimoto.
BorzdeG
pushed a commit
to BorzdeG/asdf-golang
that referenced
this pull request
Jul 28, 2024
* Add Makefile for Hygiene Signed-off-by: Sora Morimoto <[email protected]> * make format Signed-off-by: Sora Morimoto <[email protected]> --------- Signed-off-by: Sora Morimoto <[email protected]> Co-authored-by: Kenny Parnell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.