This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Slow zoom out with fingers gets stuck on scale less than 1 fix(It wasn't recovering back to scale 1) #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onPanResponderRelease now always knows how to bounce back to scale 1 when it's zoomed out less than scale 1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onPanResponderReleasenow always knows how to bounce back to scale 1 when it's zoomed out less than scale 1.Previously, when you are gently zooming out and stopped your gesture slowly, then it holds the picture's scale to the value even if it's lower than 1. You had to zoom-out with flicker your fingers then it will successfully bounce back to scale 1.
After this fix, it will always zoom back to scale 1 after your fingers are released no matter what speed of your fingers was at.