Skip to content

Sometimes messages with type=3 have ext timestamp field, and ext time… #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −5
Open

Sometimes messages with type=3 have ext timestamp field, and ext time… #1462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ngx_rtmp_handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,15 +402,23 @@ ngx_rtmp_recv(ngx_event_t *rev)
pp[2] = *p++;
pp[1] = *p++;
pp[0] = *p++;
}

if (st->len == 0) {

/* Messages with type=3 should
* never have ext timestamp field
* according to standard.
* However that's not always the case
* in real life */
st->ext = (ext && cscf->publish_time_fix);
* in real life.
* Sometimes ext timestamp is same as delta time
* of the first message chunk.
*/
if (fmt == 3 && st->dtime != timestamp) {
p -= 4;
ext = 0;
timestamp = 0;
}
}

if (st->len == 0) {
if (fmt) {
st->dtime = timestamp;
} else {
Expand Down