Skip to content

Conversation

krisfremen
Copy link
Member

@krisfremen krisfremen commented Sep 10, 2025

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Closes #1221

Add week_start(via kwargs to span) parameter to floor() and ceil()

@krisfremen krisfremen changed the title add kwargs to ceil and floor to pass week_start Add week_start parameter to floor() and ceil() Sep 10, 2025
@krisfremen krisfremen self-assigned this Sep 10, 2025
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (403c29f) to head (b999fd9).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2324      2339   +15     
  Branches       357       357           
=========================================
+ Hits          2324      2339   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add week_start parameter to floor() and ceil()
1 participant