Make Seq generic #57
Merged
Make Seq generic #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attribute Also, can you please squash the commits into single commit, the intermediate two commits don't compile by themselves. You can keep the example diff in separate commit if you prefer to. Trying to see if we can replace traits One and Zero. Any ideas ? |
| @@ -2,49 +2,49 @@ extern crate libc; | |||
|
|
|||
| use std::fmt; | |||
| use std::default::Default; | |||
| use self::libc::{c_double}; | |||
| use std::num::{One, Zero}; | |||
|
|
|||
| /// Sequences are used for indexing Arrays | |||
| #[derive(Copy, Clone)] | |||
| #[repr(C)] | |||
There was a problem hiding this comment.
Would you even need this anymore necessarily?
|
@jnicholls Sure, implementing the trait ourselves is one option. |
|
I updated it to implement the |
| } | ||
|
|
||
| impl Zero for u8 { fn zero() -> Self { 0 } } | ||
| impl Zero for u16 { fn zero() -> Self { 0 } } |
|
Alright, macros for @jnicholls :) |
|
👍 |
|
Excellent! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.