Interop fixes #159
Merged
Interop fixes #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call arr._reorder instead of transpose when using row major. - Disable additional copies when is_device is false
umar456
approved these changes
Sep 18, 2017
| ------ | ||
| - An exception is thrown when output is not None and it is not contiguous. | ||
| - When output is None, The returned array is in fortran contiguous order. |
There was a problem hiding this comment.
nit: I prefer column major order rather than Fortran contiguous order.
There was a problem hiding this comment.
@umar456 That's the notation numpy uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.