Skip to content

Conversation

luckysori
Copy link
Collaborator

We were using a rust-secp256k1-zkp branch for Musig, but it's better to use the branch that will eventually merge into rust-secp256k1.

Incidentally, we still need the dependency on rust-secp256k1-zkp in ark-dlc-sample, because we are using Musig adaptor signatures for that one. But that can be a regular git dependency, since ark-dlc-sample will not be released to crates.io.


We will need to release a new ark-secp256k1 crate, replacing this one: https://crates.io/crates/ark-secp256k1-zkp/0.10.0.

@luckysori luckysori requested a review from bonomat May 5, 2025 04:31
@luckysori luckysori self-assigned this May 5, 2025
@luckysori luckysori force-pushed the feat/use-secp256k1-for-musig branch from c96f9fd to f80f203 Compare May 5, 2025 04:32
Copy link
Collaborator

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We were using a `rust-secp256k1-zkp` branch for Musig, but it's better
to use the branch that will eventually merge into `rust-secp256k1`.

Incidentally, we still need the dependency on `rust-secp256k1-zkp` in
`ark-dlc-sample`, because we are using Musig adaptor signatures for
that one. But that can be a regular git dependency, since
`ark-dlc-sample` will not be released to crates.io.
@luckysori luckysori force-pushed the feat/use-secp256k1-for-musig branch from 4fee41d to 207ebb2 Compare May 5, 2025 04:45
@bonomat bonomat merged commit 9c22d3f into arkade-os:master May 5, 2025
10 checks passed
@bonomat bonomat deleted the feat/use-secp256k1-for-musig branch May 5, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants