Add upper bound to MetaTrader5 dependency (<=5.0.5370) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update app_lifespan to read from MT5_LOGIN, MT5_PASSWORD, MT5_SERVER, MT5_PATH - Consolidate on single source of truth for environment variables - Remove unused imports (argparse, logging, load_dotenv) - Remove __main__ block (replaced by cli.py)
- Remove redundant os.environ assignments (already handled by Click's envvar) - Remove unused os import - Click's envvar parameter reads from environment, no need to rewrite - Environment variables available during server lifespan execution
…e CLI - Update lifespan to read from MT5_LOGIN, MT5_PASSWORD, MT5_SERVER, MT5_PATH - Fix argparse usage (remove invalid envvar parameter) - Add CLI arg precedence: CLI args override environment variables - Fall back to environment variables when CLI args not provided - Set resolved values to environment for lifespan handler access
- Change 'Option B: HTTP/SSE Transport' to 'Option B: HTTP Transport' - Update command from --transport sse to --transport http - Update endpoint from /sse to /mcp (Streamable HTTP standard) - Remove deprecated SSE transport references - Update security guidelines to focus on reverse proxy approach
- Remove duplicate/conflicting variable definitions - Use MT5_LOGIN, MT5_PASSWORD, MT5_SERVER, MT5_PATH as canonical variables - Remove MCP_TRANSPORT and other unrelated variables - Add clear comments for optional vs required settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest metatrader5 5.0.5387 renamed from widely used
MetaTrader5tometatrader5, breaking code. This PR prevents problematic version to be used/installed.