Skip to content

Conversation

@chiara-septentrio
Copy link
Contributor

Added a new library for Septentrio GNSS

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

A problem was found with your submission https://github.com/septentrio-gnss/Septentrio_Arduino_library

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Aug 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @chiara-septentrio
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Arduino Lint has suggestions for possible improvements to https://github.com/septentrio-gnss/Septentrio_Arduino_library:

Linting library in Septentrio_Arduino_library
INFO: No header file found matching library name (Eridano-Septentrio.h). Best practices are for primary header filename 
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Eridano-Septentrio is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format  
         (Rule LP010)                                                                                            

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in Septentrio_Arduino_library/examples/log_PVTGeodetic

Linter results for project: no errors or warnings

-------------------

Linting sketch in Septentrio_Arduino_library/examples/ntrip_client

Linter results for project: no errors or warnings

-------------------

Linting sketch in Septentrio_Arduino_library/examples/read_GGA

Linter results for project: no errors or warnings

-------------------

Linting sketch in Septentrio_Arduino_library/examples/read_PVTGeodetic

Linter results for project: no errors or warnings

-------------------

Linting sketch in Septentrio_Arduino_library/examples/write_command

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@chiara-septentrio
Copy link
Contributor Author

Updated the library with a tag @ArduinoBot

@github-actions github-actions bot requested a review from per1234 August 5, 2024 07:36
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the request for review from per1234 August 5, 2024 07:37
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Arduino Lint has suggestions for possible improvements to https://github.com/septentrio-gnss/Septentrio_Arduino_library:

Linting library in Septentrio_Arduino_library
INFO: No header file found matching library name (Eridano-Septentrio.h). Best practices are for primary header filename 
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Eridano-Septentrio is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format  
         (Rule LP010)                                                                                            

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in Septentrio_Arduino_library/examples/log_PVTGeodetic

Linter results for project: no errors or warnings

-------------------

Linting sketch in Septentrio_Arduino_library/examples/ntrip_client

Linter results for project: no errors or warnings

-------------------

Linting sketch in Septentrio_Arduino_library/examples/read_GGA

Linter results for project: no errors or warnings

-------------------

Linting sketch in Septentrio_Arduino_library/examples/read_PVTGeodetic

Linter results for project: no errors or warnings

-------------------

Linting sketch in Septentrio_Arduino_library/examples/write_command

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit a64d41b into arduino:main Aug 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/septentrio-gnss/Septentrio_Arduino_library/

github-actions bot pushed a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant