Skip to content

Request to add library to official library list #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2024
Merged

Request to add library to official library list #4518

merged 1 commit into from
May 15, 2024

Conversation

johannesprins
Copy link
Contributor

@github-actions github-actions bot added the topic: submission Add library to the list label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

A problem was found with your submission https://github.com/bonkmachines/ctrl-arduino

❌ ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @johannesprins
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@johannesprins
Copy link
Contributor Author

@ArduinoBot library.properties was updated

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

A problem was found with your submission https://github.com/bonkmachines/ctrl-arduino

❌ ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @johannesprins
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@johannesprins
Copy link
Contributor Author

@ArduinoBot It's right here: https://github.com/bonkmachines/ctrl-arduino/blob/main/library.properties

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

A problem was found with your submission https://github.com/bonkmachines/ctrl-arduino

❌ ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @johannesprins
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@johannesprins
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/bonkmachines/ctrl-arduino:

Linting library in ctrl-arduino
ERROR: Library name Arduino_CTRL starts with "Arduino". These names are reserved for official libraries.     
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP012)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in ctrl-arduino/examples/button/button_advanced

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/button/button_alternative

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/button/button_basic

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/led/led_blink

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/led/led_fade

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/potentiometer/potentiometer_advanced

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/potentiometer/potentiometer_alternative

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/potentiometer/potentiometer_basic

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/rotary_encoder/rotary_encoder_advanced

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/rotary_encoder/rotary_encoder_alternative

Linter results for project: no errors or warnings

-------------------

Linting sketch in ctrl-arduino/examples/rotary_encoder/rotary_encoder_basic

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @johannesprins
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@johannesprins
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot merged commit e4d6cc9 into arduino:main May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/bonkmachines/ctrl-arduino/

github-actions bot pushed a commit that referenced this pull request May 15, 2024
@ArduinoBot
Add submission # 4518
1b819cf 
#4518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
topic: submission Add library to the list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johannesprins