Implementing binary file open/download (requires micropython.js 1.5.0) #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
ubidefeo
changed the title
ubidefeo
changed the title
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
ubidefeo
changed the title
murilopolese
approved these changes
Nov 19, 2024
Contributor
murilopolese
left a comment
murilopolese
left a comment
There was a problem hiding this comment.
I didn't test it a lot but the code is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order not to break the current fs_cat behaviour which is also used to load files into the editor, I have implemented a couple more methods that only deal with transferring files from the board to the computer.
The reading in chunks is converted to a comma separated string of integers and JS handles the creation of a Buffer from the extracted integers.
I tested downloading text files and binaries and executing an
md5sumof the file before being uploaded to the board and after being downloaded